Feature: Added discussion types

package.json

@@ -1,6 +1,6 @@
 {
   "name": "pull-request-analytics-action",
-  "version": "1.2.2",
+  "version": "1.3.0",
   "description": "github action to show prs report",
   "main": "build/index.js",
   "scripts": {

src/controllers/data/preparations/collectData.ts

@@ -15,13 +15,16 @@ export const collectData = (
   const collection: Record<string, Record<string, Collection>> = { total: {} };
 
   data.pullRequestInfo.forEach((pullRequest, index) => {
-    const closedDate = pullRequest?.closed_at
-      ? parseISO(pullRequest?.closed_at)
+    if (pullRequest === undefined || pullRequest === null) {
+      return;
+    }
+    const closedDate = pullRequest.closed_at
+      ? parseISO(pullRequest.closed_at)
       : null;
 
     const dateKey = closedDate ? format(closedDate, "M/y") : "invalidDate";
 
-    const userKey = pullRequest?.user.login || "invalidUser";
+    const userKey = pullRequest.user.login || "invalidUser";
     if (!collection[userKey]) {
       collection[userKey] = {};
     }
@@ -40,13 +43,13 @@ export const collectData = (
       });
     });
 
-    prepareReviews(data, collection, index, dateKey, pullRequest?.user.login);
+    prepareReviews(data, collection, index, dateKey, pullRequest.user.login);
     prepareDiscussions(
       data.comments,
       collection,
       index,
       dateKey,
-      pullRequest?.user.login
+      pullRequest.user.login
     );
   });
 

src/controllers/data/preparations/types.ts

@@ -10,15 +10,15 @@ type TimelinePoints = {
 
 type DiscussionResult = {
   total: number;
-  agreed: number;
-  disagreed: number;
-  unresolved: number;
+  agreed?: number;
+  disagreed?: number;
+  unresolved?: number;
 };
 
 type DiscussionType = {
   [key: string]: {
-    received: DiscussionResult;
-    conducted: DiscussionResult;
+    received?: DiscussionResult;
+    conducted?: DiscussionResult;
   };
 };
 

src/controllers/data/preparations/utils/getDiscussionType.spec.ts

@@ -0,0 +1,21 @@
+import { getDiscussionType } from "./getDiscussionType";
+
+describe("check getDiscussionType", () => {
+  it("check text without value ", () => {
+    expect(getDiscussionType("text text")).toEqual([]);
+  });
+  it("check value in text", () => {
+    expect(getDiscussionType("text [[value1]] text")).toEqual(["value1"]);
+  });
+  it("check multiple values in text", () => {
+    expect(getDiscussionType("text [[value1]] [[value2]] text")).toEqual([
+      "value1",
+      "value2",
+    ]);
+  });
+  it("check value with different symbols", () => {
+    expect(
+      getDiscussionType("text [[value-1]] [[value:2]] [[value.3]]text")
+    ).toEqual(["value-1", "value:2", "value.3"]);
+  });
+});

src/controllers/data/preparations/utils/getDiscussionType.ts

@@ -0,0 +1,9 @@
+export const getDiscussionType = (text: string) => {
+  const regex = /\[\[(.*?)\]\]/g;
+  return (
+    text
+      .match(regex)
+      ?.map((el) => el.replace(/[\[\]]/g, ""))
+      .filter((el) => el) || []
+  );
+};