Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow 0.53 compatibility #68

Closed
wants to merge 1 commit into from
Closed

Conversation

mwiencek
Copy link

flow 0.53 changed how React things are typed. They've provided a flow-upgrade utility to automatically convert things, so I've ran that to generate the changes in this commit.

flow 0.53 changed how React things are typed. They've provided a
`flow-upgrade` utility to automatically convert things, so I've ran that
to generate the changes in this commit.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cbb0887 on mwiencek:flow-0.53 into 823bcc9 on AlexGilleran:master.

@AlexGilleran
Copy link
Owner

Thanks for the PR @mwiencek!

As far as I can tell the new definitions for 0.53 aren't backwards-compatible, so I've created a commit here that puts your new defs in a new file - this way people on old Flow won't find their types breaking and people on new Flow can opt-in to the new types. I'll replace the definitions in the main file with the new ones in a future major version change.

Does that make sense @mwiencek? I don't actually use flow myself :).

@mwiencek
Copy link
Author

Yeah, that sounds better, thanks. :)

It seems that flow only reads jsx-control-statements.flow.js by default (I couldn't find this behavior documented anywhere, so if you know of anything I'd be curious), so I needed the following in my .flowconfig to use the new defs:

[ignore]
.*/node_modules/jsx-control-statements/jsx-control-statements.flow.js

[libs]
./node_modules/jsx-control-statements/jsx-control-statements.latest.flow.js

@mwiencek mwiencek closed this Aug 20, 2017
@mwiencek mwiencek deleted the flow-0.53 branch August 20, 2017 04:31
@AlexGilleran
Copy link
Owner

Thanks for sharing that, have published a new version and linked to that explanation in the readme :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants