feat(semantic-release): add semantic release to the project #114
Conversation
|
I'm not sure if |
|
@fccoelho is the only maintainer there: https://pypi.org/project/pysus/ |
|
in general looks good to me. you can take a look at here https://github.com/arxlang/arx/blob/main/.github/workflows/release.yaml#L6 check that some steps has |
| @@ -99,10 +98,6 @@ def test_type_convertion(self): | |||
| self.assertTrue(self.dbf_name.exists()) | |||
| assert not all(df.dtypes == "object") | |||
|
|
|||
| def test_geocode(self): | |||
| self.assertTrue(self.data_pickle.exists()) | |||
There was a problem hiding this comment.
I didn't see much use for this test..
There was a problem hiding this comment.
I don't remember if at some point sinan generates this pickle file, but from the name of the test it seems that this test is incomplete.
| def test_read_dbc(self): | ||
| df = read_dbc(str(self.dbc_fname)) | ||
| self.assertIsInstance(df, pd.DataFrame) | ||
| self.assertGreater(df.size, 0) | ||
|
|
||
| def test_read_dbc_dbf(self): |
There was a problem hiding this comment.
I've split this test and remove the duplicated part, that is now skipped
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
I've also noticed
requirements.txtand asetup.pyfile, I chose to use the poetry to do the build, since setuptools is not as dynamic