forked from celo-org/snark-setup
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to snarkVM #317
Merged
Merged
Upgrade to snarkVM #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2021
emmorais
approved these changes
Jul 28, 2021
apruden2008
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
enhancement
New feature or request
refactor
Changes which affect the maintainability of the code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR upgrades the
aleo-setup
repository to snarkVM on thetestnet2
branch, which uses hash to curve for curve generators and all cryptographic primitives related to account derivation for this repository.rand
tov0.8
and enforcesCryptoRng
across the boardrand_xorshift
in favor ofrand_chacha
to enforceCryptoRng
snarkOS-toolkit
in favor ofsnarkVM-dpc
1.53.0
Remarks
aleo-setup/phase2
needs to be reviewed in detail, it is very much out of date at this point. Most notably, some things to watch out for are:ChaChaRng
basedhash_to_g2
implementation in here.libzexe
which is deprecated.aleo_compatibility
integration test is commented out, given we do not need to cross-check anymore. This file should not be deleted, but rather updated to sanity check the Phase2 execution. Please see the equivalentphase1/tests/marlin.rs
file to see how this conversion was done.The same applies for the
setup2
module. Most notable:rng
inSetup2::new()
was previously hardcoded terribly asXorShiftRng::from_seed([0u8; 16])
snarkvm_dpc::testnet2
however the instantiation of this insidesetup2
has not been inspected.libzexe
which is deprecated.