Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When Freshping gets a non-2xx response for a webhook request, it retries a lot #1

Closed
Aldaviva opened this issue Jul 13, 2024 · 1 comment
Closed

When Freshping gets a non-2xx response for a webhook request, it retries a lot #1

Aldaviva opened this issue Jul 13, 2024 · 1 comment
Assignees
@Aldaviva
Labels
enhancement New feature or request
Milestone
2.0.0

Comments

@Aldaviva
Copy link
Owner

However, FreshPager returns 404 for unknown checks, so clicking the Test button on a Webhook integration triggers a finite loop of requests.

To work around this, FreshPager should return a 2xx status code for missing checks, such as 204 No Content.
@Aldaviva Aldaviva added the enhancement New feature or request label Jul 13, 2024
@Aldaviva Aldaviva self-assigned this Jul 13, 2024
Aldaviva added a commit that referenced this issue Aug 3, 2024
@Aldaviva
#1: When Freshping gets a non-2xx response for a webhook request, it …
4e33a77 
…retries a lot
@Aldaviva
Copy link
Owner Author

Aldaviva commented Aug 3, 2024

When a service with the given name is not found, it now returns 204 instead of 404.

@Aldaviva Aldaviva closed this as completed Aug 3, 2024
@Aldaviva Aldaviva added this to the 1.0.2 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aldaviva Aldaviva

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@Aldaviva