Import flatpickr translations into Alchemy admin #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alchemy 7.0 uses importmaps and JS modules for flatpickr (and other JS dependencies). We need to register the translations as additional JS module imports in order to be available to Flatpickr.
We need at least Alchemy 7.0.4 for the ability to add additional admin JS module imports. See AlchemyCMS/alchemy_cms#2588
sascha-karnatz
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alchemy 7.0 uses importmaps and JS modules for
flatpickr (and other JS dependencies). We need
to register the translations as additional JS
module imports in order to be available to
Flatpickr.
This raises the supported Alchemy version to >= 7.0.4 because we need the ability to add additional admin JS module imports.
See AlchemyCMS/alchemy_cms#2588