Preload SVG Icon Sprite #3046
Merged
Preload SVG Icon Sprite #3046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
preload-svg-icon-font
branch
from
cbaeaf7
to
4557796
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3046 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 235 235
Lines 6324 6324
=======================================
Hits 6111 6111
Misses 213 213 ☔ View full report in Codecov by Sentry. |
This is not a font
Using the alchemy-icon so we can make use of the already loaded svg icon sprite.
Preloading the svg icon sprite with `crossorigin` allowed should fix CORS issues. See https://oreillymedia.github.io/Using_SVG/extras/ch10-cors.html Fixes #2937
tvdeyen
force-pushed
the
preload-svg-icon-font
branch
from
4557796
to
fa97f33
Compare
sascha-karnatz
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Preloading the svg icon sprite with
crossoriginallowed shouldfix CORS issues.
See https://oreillymedia.github.io/Using_SVG/extras/ch10-cors.html
Fixes #2937
Notable changes
Changes how icons are used in the Alchemy Modules definition. Please seperate icon name and style into
Checklist