[7.3-stable] Make page select portable #3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values where not correct (cherry picked from commit 5f995e0)
We want to get rid of Sass variables and use custom properties instead. (cherry picked from commit e0dbaa0)
By using it's own css file and include that in the component we can use the page select outside of Alchemy UI (ie. Solidus). Making use of custom properties with default values so that the style can be overwritten if necessary. (cherry picked from commit d998c56)
Some languages are very verbose, so we need more space for the parent page label (cherry picked from commit d85fdce)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.3-stable #3038 +/- ##
=============================================
Coverage ? 96.47%
=============================================
Files ? 237
Lines ? 6405
Branches ? 0
=============================================
Hits ? 6179
Misses ? 226
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.3-stable:Questions ?
Please refer to the Backport tool documentation