Use alchemy_display_name for page actor names #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
added
backport-to-7.0-stable
sascha-karnatz
approved these changes
Sep 6, 2024
If you have a user class that does not implement name (eg. `Spree::User` or a generic `User` class) it would return `nil` for Page actor methods (creator, updater, locker). We already use `alchemy_display_name` for the current logged in user displayed in the admin frame. Using this for the Page actor methods to be consistant and allow custom user classes to present a user by it.
tvdeyen
force-pushed
the
use-alchemy_display_name
branch
from
ebbb2fd to
00dd34e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3027 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 237 237
Lines 6404 6404
=======================================
Hits 6178 6178
Misses 226 226 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 6, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
If you have a user class that does not implement
name (eg.
Spree::Useror a genericUserclass) it would returnnilfor Page actor methods (creator, updater, locker).We already use
alchemy_display_namefor the current logged in user displayed in the admin frame.Using this for the Page actor methods to be consistant and allow custom user classes to present a user by it.
Checklist