Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alchemy resources table into resource_table partial #3026

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 5, 2024

What is this pull request for?

To make upgrades easier for sites that might have the table partial overwritten, we introduce a new partial for the new resource table and leverage that for our own views.

Checklist

To make upgrades easier for sites that might have the `table` partial
overwritten, we introduce a new partial for the new resource table
and leverage that for our own views.
@tvdeyen tvdeyen requested a review from a team as a code owner September 5, 2024 14:08
@tvdeyen tvdeyen added this to the 7.3 milestone Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (1aba04f) to head (c35d0fe).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3026   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         237      237           
  Lines        6404     6404           
=======================================
  Hits         6178     6178           
  Misses        226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit bc022cc into main Sep 5, 2024
39 checks passed
@tvdeyen tvdeyen deleted the move-resource-table-partial branch September 5, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants