Fix asset precompilation #3024
Merged
Fix asset precompilation #3024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are inline styles in the menubar partial now.
We can just rely on the browser.
Current sprockets will replace the contents of url() statements in CSS with their fingerprinted versions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3024 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 237 237
Lines 6404 6404
=======================================
Hits 6178 6178
Misses 226 226 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Fix asset precompilation in host apps with SassC in environments other than development. We were still using the old
image-urlSass directive, whereas modern Sass/Sprockets can fingerprint assets referenced in URL directives directly.Notable changes (remove if none)
Makes the current main branch deployable.
Screenshots
None :)
Checklist