Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.2-stable] Allow to set input_type on Datetime ingredient editor #3016

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 3, 2024

Backport

This will backport the following commits from main to 7.2-stable:

Questions ?

Please refer to the Backport tool documentation

Since the Datetime ingredient stores date and time values
it should be possible to set the input_type to either

- time
- date
- datetime

(cherry picked from commit 02a69a6)

# Conflicts:
#	app/views/alchemy/ingredients/_datetime_editor.html.erb
@tvdeyen tvdeyen requested a review from a team as a code owner September 3, 2024 20:01
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (3099b68) to head (8fbca63).
Report is 4 commits behind head on 7.2-stable.

Additional details and impacted files
@@              Coverage Diff               @@
##           7.2-stable    #3016      +/-   ##
==============================================
+ Coverage       95.99%   96.00%   +0.01%     
==============================================
  Files             233      233              
  Lines            6315     6315              
==============================================
+ Hits             6062     6063       +1     
+ Misses            253      252       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 337d5f2 into 7.2-stable Sep 4, 2024
33 checks passed
@tvdeyen tvdeyen deleted the backport/7.2-stable/pr-3002 branch September 4, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants