Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix builds #3006

Merged
merged 3 commits into from
Sep 3, 2024
Merged

[CI] Fix builds #3006

merged 3 commits into from
Sep 3, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 2, 2024

Fixes build issues with latest Rails 7.1.4 and Chrome v128

They may be called multiple times and we actually must not care in specs
Chrome 128 introduced a new search engine selection.
By using the Rails' headless_chrome setup and disabling
the feature it works with newer versions of chrome.
@tvdeyen tvdeyen requested a review from a team as a code owner September 2, 2024 15:08
@tvdeyen tvdeyen changed the title Fix builds [CI] Fix builds Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (49f1c47) to head (c0c1332).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3006   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         237      237           
  Lines        6393     6393           
=======================================
  Hits         6167     6167           
  Misses        226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 86cdac7 into AlchemyCMS:main Sep 3, 2024
36 checks passed
@tvdeyen tvdeyen deleted the fix-builds branch September 3, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant