Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Datetime ingredient in local time zone #3003

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 28, 2024

What is this pull request for?

Datetime values are stored in UTC in the database.
We need to render them in the local timezone.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from a team as a code owner August 28, 2024 19:49
@tvdeyen tvdeyen added this to the 7.3 milestone Aug 28, 2024
@tvdeyen tvdeyen added the backport-to-7.2-stable Needs to be backported to 7.2-stable label Aug 28, 2024
@tvdeyen tvdeyen removed this from the 7.3 milestone Aug 28, 2024
@tvdeyen tvdeyen added backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable labels Aug 28, 2024
@tvdeyen tvdeyen force-pushed the datetime-view-time-zone branch from a715d48 to b471bca Compare August 29, 2024 07:47
@tvdeyen tvdeyen mentioned this pull request Aug 29, 2024
5 tasks
@tvdeyen tvdeyen force-pushed the datetime-view-time-zone branch 2 times, most recently from e31a11f to 2a735df Compare August 29, 2024 09:00
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (3513fd1) to head (226c97f).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3003   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files         233      233           
  Lines        6308     6309    +1     
=======================================
+ Hits         6086     6087    +1     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Datetime values are stored in UTC in the database.
We need to render them in the local timezone.
@tvdeyen tvdeyen force-pushed the datetime-view-time-zone branch from 2a735df to 226c97f Compare August 29, 2024 09:40
@tvdeyen tvdeyen enabled auto-merge August 29, 2024 09:54
@tvdeyen tvdeyen merged commit 49f1c47 into main Aug 29, 2024
36 checks passed
@tvdeyen tvdeyen deleted the datetime-view-time-zone branch August 29, 2024 11:14
@alchemycms-bot
Copy link
Collaborator

💔 All backports failed

Status Branch Result
7.0-stable Backport failed because of merge conflicts
7.1-stable Backport failed because of merge conflicts
7.2-stable Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 3003

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Member Author

tvdeyen commented Sep 3, 2024

💚 All backports created successfully

Status Branch Result
7.0-stable

Questions ?

Please refer to the Backport tool documentation

@tvdeyen
Copy link
Member Author

tvdeyen commented Sep 3, 2024

💚 All backports created successfully

Status Branch Result
7.1-stable

Questions ?

Please refer to the Backport tool documentation

@tvdeyen
Copy link
Member Author

tvdeyen commented Sep 3, 2024

💚 All backports created successfully

Status Branch Result
7.2-stable

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-7.0-stable Needs to be backported to 7.0-stable backport-to-7.1-stable Needs to be backported to 7.1-stable backport-to-7.2-stable Needs to be backported to 7.2-stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants