Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keywords in routes mapping #2986

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 3, 2024

What is this pull request for?

Rails deprecates hash key path mapping

See: rails/rails#52422

Checklist

@tvdeyen tvdeyen requested a review from a team as a code owner August 3, 2024 23:08
@tvdeyen tvdeyen added this to the 7.3 milestone Aug 3, 2024
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (4455010) to head (1711795).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
+ Coverage   96.01%   96.44%   +0.43%     
==========================================
  Files         233      233              
  Lines        6320     6307      -13     
==========================================
+ Hits         6068     6083      +15     
+ Misses        252      224      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen force-pushed the use-kwargs-in-routes branch from a2e3565 to 1711795 Compare August 4, 2024 13:32
@tvdeyen tvdeyen merged commit 2541337 into AlchemyCMS:main Aug 10, 2024
36 checks passed
@tvdeyen tvdeyen deleted the use-kwargs-in-routes branch August 10, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant