Display ingredient validation errors inline #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
ingredient-validation-errors-inline
branch
from
5603b58 to
a15c2a5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
==========================================
- Coverage 96.02% 96.01% -0.02%
==========================================
Files 233 233
Lines 6317 6320 +3
==========================================
+ Hits 6066 6068 +2
- Misses 251 252 +1 ☔ View full report in Codecov by Sentry. |
3 tasks
tvdeyen
force-pushed
the
ingredient-validation-errors-inline
branch
from
a15c2a5 to
8a3c698
Compare
tvdeyen
changed the title
Instead of a large blob of information on top of the element we display a short notice and the error message on the input field. Also use HTML5 input validations to show the invalid state before submitting the data.
tvdeyen
force-pushed
the
ingredient-validation-errors-inline
branch
from
8a3c698 to
95d7e41
Compare
sascha-karnatz
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Instead of a large blob of information on top of the element we display a short notice and the error message on the input field.
Also use HTML5 input validations to show the invalid state before submitting the data.
Screenshots
Checklist