Resource Controller: Allow additional Ransack filters #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2979 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 233 233
Lines 6309 6309
=======================================
Hits 6058 6058
Misses 251 251 ☔ View full report in Codecov by Sentry. |
When using custom Ransack filters, this will allow combining them with the pagination. Without this, we can only combine the one ransack field we use for searching in the top bar. See AlchemyCMS#2978 for context.
mamhoff
force-pushed
the
allow-additional-ransack-filters
branch
from
d415f77 to
d8a0447
Compare
tvdeyen
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using custom Ransack filters, this will allow combining them with the pagination. Without this, we can only combine the one ransack field we use for searching in the top bar.
See #2978 for context.