Only allow to assign contentpages in menu node form #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we just want to search a value in a select2 type-ahead and not also click (select) the value.
Layoutpages are not routable (they don't have an URL and only hold content rendered elsewhere). Since menus are meant to render a list of page urls it does not make any sense to allow to assign a layoutpage to a menu node.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2967 +/- ##
=======================================
Coverage 96.00% 96.00%
=======================================
Files 232 232
Lines 6282 6284 +2
=======================================
+ Hits 6031 6033 +2
Misses 251 251 ☔ View full report in Codecov by Sentry. |
|
Looks good to me, maybe there should be a model validation as well? What du you think? |
mamhoff
approved these changes
Jul 9, 2024
|
In my opinion validations are for data integrity and this here is more a "don't shoot in your own foot" situation. Technically it is totally valid to assign any page, it just doesn't make any sense. A validation could also be harmful for existing sites. So, no, I think we should not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Layoutpages are not routable (they don't have an URL and only hold content rendered elsewhere).
Since menus are meant to render a list of page urls it does not make any sense to allow to assign a layoutpage to a menu node.
Checklist