Clear current language when switching sites #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
==========================================
+ Coverage 96.00% 96.02% +0.01%
==========================================
Files 232 233 +1
Lines 6282 6309 +27
==========================================
+ Hits 6031 6058 +27
Misses 251 251 ☔ View full report in Codecov by Sentry. |
dbwinger
force-pushed
the
switch-language-on-site-switch
branch
from
c01a91e to
e274774
Compare
|
@tvdeyen I don't mean to rush you but just wanted to make sure you saw this PR. I wondered if the codeclimate error caused you not to get alerted. I can't tell what the problem is there. |
tvdeyen
reviewed
Jul 17, 2024
dbwinger
force-pushed
the
switch-language-on-site-switch
branch
4 times, most recently
from
3a92315 to
9773f81
Compare
tvdeyen
added
backport-to-7.1-stable
tvdeyen
changed the title
|
@dbwinger would you mind to update commit message now that we changed the implementation? |
dbwinger
force-pushed
the
switch-language-on-site-switch
branch
from
9773f81 to
d6de41a
Compare
Done. |
This was referenced Jul 22, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…is associated with the current site.
What is this pull request for?
If at least one site has multiple languages, after the language is switched in the admin/pages view, the language ID is saved to session, and switching to another site does not change the language in session, which causes that language's pages to continue to be shown.
Closes #2956
This should be backported at least to 7.1.
Checklist