Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused resource update.js.erb template #2955

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 1, 2024

What is this pull request for?

This template is never used. We either redirect or render errors (via the render_errors_or_redirect) method from Admin::BaseController.

Checklist

This template is never used. We either redirect or render
errors (via the `render_errors_or_redirect`) method from
`Admin::BaseController`.
@tvdeyen tvdeyen requested a review from a team as a code owner July 1, 2024 14:37
@tvdeyen tvdeyen added this to the 7.3 milestone Jul 1, 2024
@tvdeyen tvdeyen enabled auto-merge July 1, 2024 15:01
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (80d8d91) to head (89adfb5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2955   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         232      232           
  Lines        6282     6282           
=======================================
  Hits         6031     6031           
  Misses        251      251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 72973ad into main Jul 1, 2024
35 checks passed
@tvdeyen tvdeyen deleted the remove-resource-js-erb branch July 1, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants