Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Turbo Cache in Admin #2943

Merged

Conversation

sascha-karnatz
Copy link
Contributor

What is this pull request for?

This feature does not provide a huge benefit and has some weird downsides. If the user is revisiting a view in Alchemy admin it will be slower, but at least the user is not seeing and old view which will updating a few moments later (e.g. already closed tabs, newly created pictures, etc.)

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@sascha-karnatz sascha-karnatz requested a review from a team as a code owner June 27, 2024 10:21
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (86ee06e) to head (c616844).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2943      +/-   ##
==========================================
- Coverage   95.96%   95.96%   -0.01%     
==========================================
  Files         232      232              
  Lines        6272     6271       -1     
==========================================
- Hits         6019     6018       -1     
  Misses        253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This feature does not provide a huge benefit and has some weird downsides. If the user is revisiting a view in Alchemy admin it will be slower, but at least the user is not seeing and old view which will updating a few moments later (e.g. already closed tabs, newly created pictures, etc.)
@tvdeyen tvdeyen force-pushed the disable-turbo-cache-in-admin branch from a3c038c to c616844 Compare June 27, 2024 11:56
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tvdeyen tvdeyen enabled auto-merge June 27, 2024 11:57
@tvdeyen tvdeyen merged commit 0133ea7 into AlchemyCMS:main Jun 27, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants