Remove dartsass-rails requirement from alchemy_cms.rb #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dartsass-rails is not a requirement in the gemspec and is not necessary for the application, that is using alchemy_cms. Dartsass is necessary for the dummy app and because it is in the Gemfile it will be automatically required by zeitwerk.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
- Coverage 95.96% 95.96% -0.01%
==========================================
Files 232 232
Lines 6272 6271 -1
==========================================
- Hits 6019 6018 -1
Misses 253 253 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
dartsass-rails is not a requirement in the gemspec and is not necessary for the application, that is using alchemy_cms. Dartsass is necessary for the dummy app and because it is in the Gemfile it will be automatically required by Bundler.
Checklist