Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] [js] Update tinymce 7.1.1 β†’ 7.2.0 (minor) #2935

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jun 19, 2024


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ tinymce (7.1.1 β†’ 7.2.0) Β· Repo Β· Changelog

Security Advisories 🚨

🚨 TinyMCE Cross-Site Scripting (XSS) vulnerability using noscript elements

Impact

A cross-site scripting (XSS) vulnerability was discovered in TinyMCE’s content parsing code. This allowed specially crafted noscript elements containing malicious code to be executed when that content was loaded into the editor.

Patches

This vulnerability has been patched in TinyMCE 7.2.0, TinyMCE 6.8.4 and TinyMCE 5.11.0 LTS by ensuring that content within noscript elements are properly parsed.

Fix

To avoid this vulnerability:

  • Upgrade to TinyMCE 7.2.0 or higher.
  • Upgrade to TinyMCE 6.8.4 or higher for TinyMCE 6.x.
  • Upgrade to TinyMCE 5.11.0 LTS or higher for TinyMCE 5.x (only available as part of commercial long-term support contract).

Acknowledgements

Tiny thanks Malav Khatri and another reporter for their help identifying this vulnerability.

References

For more information

If you have any questions or comments about this advisory:

🚨 TinyMCE Cross-Site Scripting (XSS) vulnerability using noneditable_regexp option

Impact

A cross-site scripting (XSS) vulnerability was discovered in TinyMCE’s content extraction code. When using the noneditable_regexp option, specially crafted HTML attributes containing malicious code were able to be executed when content was extracted from the editor.

Patches

This vulnerability has been patched in TinyMCE 7.2.0, TinyMCE 6.8.4 and TinyMCE 5.11.0 LTS by ensuring that, when using the noneditable_regexp option, any content within an attribute is properly verified to match the configured regular expression before being added.

Fix

To avoid this vulnerability:

  • Upgrade to TinyMCE 7.2.0 or higher.
  • Upgrade to TinyMCE 6.8.4 or higher for TinyMCE 6.x.
  • Upgrade to TinyMCE 5.11.0 LTS or higher for TinyMCE 5.x (only available as part of commercial long-term support contract).

References

For more information

If you have any questions or comments about this advisory:

Release Notes

7.2.0 (from changelog)

Added

  • Added options.debug API that logs the initial raw editor options to console. #TINY-10605
  • Added referrerpolicy as a valid attribute for an iframe element. #TINY-10374
  • New onInit and stretched properties to the HtmlPanel dialog component. #TINY-10900
  • Added support for querying the state of the mceTogglePlainTextPaste command. #TINY-10938
  • Added for option to dialog label components to improve accessibility. The value must be another component on the same dialog. #TINY-10971

Improved

  • Dialog slider components now emit an onChange event when using arrow keys. #TINY-10428
  • Accessibility for element path buttons, added tooltip to describe the button and removed incorrect aria-level attribute. #TINY-10891
  • Improve merging of inserted inline elements by removing nodes with redundant inheritable styles. #TINY-10869
  • Improved Find & Replace dialog accessibility by changing placeholders to labels. #TINY-10871

Changed

  • Replaced tiny branding logo with Build with TinyMCE text and logo. #TINY-11001

Fixed

  • Deleting in a div with preceeding br elements would sometimes throw errors. #TINY-10840
  • autoresize_bottom_margin was not reliably applied in some situations. #TINY-10793
  • Fixed cases where adding a newline around a br, table or img would not move the cursor to a new line. #TINY-10384
  • Focusing on contenteditable="true" element when using editable_root: false and inline mode causing selection to be shifted. #TINY-10820
  • Corrected the role attribute on listbox dialog components to combobox when there are no nested menu items. #TINY-10807
  • HTML entities that were double decoded in noscript elements caused an XSS vulnerability. #TINY-11019
  • It was possible to inject XSS HTML that was not matching the regexp when using the noneditable_regexp option. #TINY-11022

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 2 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot requested a review from a team as a code owner June 19, 2024 16:06
@depfu depfu bot added the depfu label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 95.96%. Comparing base (0a14eb2) to head (4654546).

❗ Current head 4654546 differs from pull request most recent head f9c589b

Please upload reports for the commit f9c589b to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2935   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         232      232           
  Lines        6272     6272           
=======================================
  Hits         6019     6019           
  Misses        253      253           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Rebuilt packages after updating dependencies.

[skip ci]
@tvdeyen tvdeyen merged commit 2168bdb into main Jun 20, 2024
1 check passed
@tvdeyen tvdeyen deleted the depfu/update/yarn/tinymce-7.2.0 branch June 20, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants