Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove to_jq_upload #2931

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Remove to_jq_upload #2931

merged 1 commit into from
Jun 13, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jun 13, 2024

What is this pull request for?

We do not use the response files in the new Uploader just the message. Since this is a private method we can simply remove it.

Checklist

We do not use the response files in the new Uploader just
the message. Since this is a private method we can simply
remove it.
@tvdeyen tvdeyen added this to the 7.3 milestone Jun 13, 2024
@tvdeyen tvdeyen requested a review from a team as a code owner June 13, 2024 06:30
@tvdeyen tvdeyen enabled auto-merge June 13, 2024 06:36
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (e98664c) to head (98254d1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2931      +/-   ##
==========================================
- Coverage   95.97%   95.96%   -0.01%     
==========================================
  Files         232      232              
  Lines        6280     6272       -8     
==========================================
- Hits         6027     6019       -8     
  Misses        253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit ef64805 into main Jun 13, 2024
35 checks passed
@tvdeyen tvdeyen deleted the remove-to-jq_upload branch June 13, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants