Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RoutingConstraints): Allow Turbo Stream requests #2913

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(RoutingConstraints): Allow Turbo Stream requests #2913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/alchemy/routing_constraints.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def matches?(request)
# because it could be a legacy route that needs to be redirected.
#
def handable_format?
@request.format.symbol.nil? || (@request.format.symbol == :html)
@request.format.symbol.nil? || @request.format.html?
end

# We don't want to handle the Rails info routes.
Expand Down
8 changes: 8 additions & 0 deletions spec/routing/routing_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,14 @@
end
end

describe "Turbo stream requests" do
it do
expect({
get: "/contact/thanks.turbo_stream"
}).to be_routable
end
end

context "for admin interface" do
context "default" do
it "should route to admin dashboard" do
Expand Down