Add name attribute to Preview IFrame #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Alchemy 7.1, the preview Iframe had a name attribute that could be reference from inside the iframe by using `window.name`. With 7.2, this isn't the case anymore, and our (admittedly a bit special implementation) of previews have stopped working because of this missing attribute.
sascha-karnatz
approved these changes
Jun 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2908 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 232 232
Lines 6273 6273
=======================================
Hits 6020 6020
Misses 253 253 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
In Alchemy 7.1, the preview Iframe had a name attribute that could be reference from inside the iframe by using
window.name. With 7.2, this isn't the case anymore, and our (admittedly a bit special implementation) of previews have stopped working because of this missing attribute.