Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inline styles for menubar component #2893

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented May 23, 2024

What is this pull request for?

Since we use shadow dom anyway we can just inline the styles and remove the necessity to precompile it.

Screenshots

closed

menubar-closed

open

menubar-open

localized

menubar-de

open focus

menubar-focus

Checklist

@tvdeyen tvdeyen requested a review from a team as a code owner May 23, 2024 20:25
@tvdeyen tvdeyen added this to the 7.2 milestone May 23, 2024
@tvdeyen tvdeyen requested review from sascha-karnatz and removed request for sascha-karnatz May 23, 2024 20:25
Since we use shadow dom anyway we can just inline the styles
and remove the necessity to precompile it.
@tvdeyen tvdeyen force-pushed the menubar-inline-styles branch from 656f5c5 to 98ca8f8 Compare May 24, 2024 07:52
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (70b0d49) to head (98ca8f8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2893   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         230      230           
  Lines        6258     6258           
=======================================
  Hits         6005     6005           
  Misses        253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit a8c2c23 into main May 24, 2024
35 of 36 checks passed
@tvdeyen tvdeyen deleted the menubar-inline-styles branch May 24, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants