fix(node-select): Display order and seperator style #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List nodes sorted by `lft` so they appear in nested sorted order.
Makes it more readable and consistant.
tvdeyen
force-pushed
the
node-select-order-and-style
branch
from
e49e2b5 to
89ad057
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2877 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 229 229
Lines 6224 6224
=======================================
Hits 5971 5971
Misses 253 253 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
List nodes sorted by
lftso they appear in nested sorted order.Also make the node-select result list more readable and consistent.
Screenshots
Before
After
Checklist