Always show element tabs if the page has fixed elements #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2852 +/- ##
==========================================
- Coverage 95.86% 95.86% -0.01%
==========================================
Files 229 229
Lines 6211 6209 -2
==========================================
- Hits 5954 5952 -2
Misses 257 257 ☔ View full report in Codecov by Sentry. |
tvdeyen
changed the title
tvdeyen
reviewed
Apr 30, 2024
tvdeyen
reviewed
Apr 30, 2024
Remove the step to create the tab group and always show the tab group, if the page has elements, that are fixed. It makes the whole process easier and is in the UI more consistent.
Move createTab and removeTab functions into alchemy_admin - package. These two functions are still available in the Alchemy.FixedElements - namespace until we move all calls out of these js.erb - files. The functions are also migrated to vanilla Javascript.
sascha-karnatz
force-pushed
the
fixed-element-UI-improvements
branch
from
c52c61b to
1e59d50
Compare
`Page#available_element_definitions` returns elements still available for that page. Taking unique and limited elements into account. `Page#element_definitions` always returns the collections of defined elements, not matter of they have been used or not. Due to referencing the same instance variable and in memory object `available_element_definitions` was mutating the `element_definitions` object.
tvdeyen
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Checklist