Locally initialize SortableElements #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two places where we need to initialize SortableJS for elements. 1) The ElementsWindow and its top level elements 2) The nested elements inside of each element-editor Instead of using the global Alchemy object to initialize them we can import the file locally and init it where it needs to be. This makes it possible to remove another global call from the `create.js.erb` file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2815 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 225 225
Lines 6129 6129
=======================================
Hits 5879 5879
Misses 250 250 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
We have two places where we need to initialize SortableJS for elements.
Instead of using the global Alchemy object to initialize them we can import the file locally and init it where it needs to be. This makes it possible to remove another global call from the
create.js.erbfile.Checklist