Convert Preview Window into web component #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2802 +/- ##
=======================================
Coverage 95.89% 95.90%
=======================================
Files 224 224
Lines 6097 6098 +1
=======================================
+ Hits 5847 5848 +1
Misses 250 250 ☔ View full report in Codecov by Sentry. |
tvdeyen
force-pushed
the
preview-window-component
branch
from
c54e097 to
7346f1e
Compare
They have not been used for a very long time. We do not use `selectBoxIt` for many years now.
tvdeyen
force-pushed
the
preview-window-component
branch
from
7346f1e to
b0e9e7e
Compare
There are no features we need from Select2 for this
tvdeyen
force-pushed
the
preview-window-component
branch
from
b0e9e7e to
ab55aff
Compare
tvdeyen
commented
Mar 25, 2024
tvdeyen
commented
Mar 25, 2024
app/javascript/alchemy_admin/components/element_editor/publish_element_button.js
Outdated
Show resolved
Hide resolved
tvdeyen
force-pushed
the
preview-window-component
branch
from
ab55aff to
60eaba1
Compare
sascha-karnatz
approved these changes
Mar 25, 2024
tvdeyen
force-pushed
the
preview-window-component
branch
from
60eaba1 to
2388238
Compare
sascha-karnatz
approved these changes
Mar 25, 2024
Much nicer to init and handle state this way.
The details are sometimes not collapes during test runs. Since the initial state does not matter in this test we can just remove the check.
tvdeyen
force-pushed
the
preview-window-component
branch
from
2388238 to
9de5715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Converts Preview Window into custom web component.
Checklist