Transform the tag selector into a web component #2748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
force-pushed
the
add-multi-tag-component
branch
2 times, most recently
from
ed65f66 to
50e62de
Compare
sascha-karnatz
force-pushed
the
add-multi-tag-component
branch
from
50e62de to
6c5430d
Compare
tvdeyen
reviewed
Feb 27, 2024
it is still a Select2 select until we find a better alternative, but it is now abstracted into a web component and a View Component to make it easier usable and avoid initialization issues.
The select page - translation for the PageSelect View Component was missing.
sascha-karnatz
force-pushed
the
add-multi-tag-component
branch
from
6c5430d to
56c74d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
it is still a Select2 select until we find a better alternative, but it is now abstracted into a web component and a View Component to make it easier usable and avoid initialization issues.
Checklist