Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear unnecessary legacy URLs #2677

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jan 8, 2024

What is this pull request for?

When renaming a page back to a URL it used to have, we get a legacy URL that is the same as the current URL of the page, which can lead to infinite redirects. This deletes any legacy URLs that are the same as the current URL name in a callback.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

When renaming a page back to a URL it used to have, we get a legacy URL
that is the same as the current URL of the page, which can lead to
infinite redirects. This deletes any legacy URLs that are the same as
the current URL name in a callback.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

@tvdeyen tvdeyen added this to the 7.1 milestone Jan 8, 2024
@tvdeyen tvdeyen merged commit f2d045e into AlchemyCMS:main Jan 8, 2024
31 checks passed
@mamhoff mamhoff deleted the clear-unnecessary-legacy-urls branch January 8, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants