Show page status inline #2637
Merged
Show page status inline #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
page-status-inline
branch
from
0d43087 to
8f99ec6
Compare
This makes it more clear that these icons are status icons and not buttons. Also we only show them if a page has not the default state (online and not restricted) in order to unclutter the screen from obvious information.
In some Rails apps it does not work with relative imports.
It will be overlapped from themain menu otherwise.
tvdeyen
force-pushed
the
page-status-inline
branch
from
8f99ec6 to
46a47eb
Compare
It shifts the layout if positioned absolute. Since the button is already display flex we do not need the absolute position anymore anyway.
sascha-karnatz
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This makes it more clear that these icons are status icons and not buttons. Also we only show them if a page has not the default state (online and not restricted) in order to unclutter the screen from obvious information.
Screenshots
Checklist