Add Select Web Component #2606
Merged
Add Select Web Component #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same styling for selects as for Select2 - components. This will be a graceful fallback, if the Select2 component can't be rendered.
Bind the Select2 configuration with a web component to prevent initialization problems. The current solution does not work on Safari, but it will fallback to the default browser behavior.
sascha-karnatz
force-pushed
the
update_javascript/select
branch
from
065188e to
61409fd
Compare
This select has no advantage as a select2
tvdeyen
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Replace default Select2 initializer with a custom component to have an easier initialization. This web component does not work on Safari, but it will gracefully fallback to the default select behavior.
Checklist