Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Init PagePublicationFields on Pages Table #2528

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jul 31, 2023

What is this pull request for?

On the sitemap and on the Edit page, Alchemy::PagePublicationFields is run. On the table, it isn't, leading to behavior where an admin cannot un-publish or publish a page from the pages table.

Notable changes (remove if none)

Fixes a little Bug

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. took me a while to understand the issue reading the commit message/PR description

app/views/alchemy/admin/pages/_table.html.erb Outdated Show resolved Hide resolved
@tvdeyen tvdeyen changed the title Bugfix: Run PagePublicationFields on Pages Table Bugfix: Init PagePublicationFields on Pages Table Jul 31, 2023
On the Sitemap and on the Edit page, `Alchemy::PagePublicationFields` is
initialized. On the table, it isn't, leading to behavior where an admin cannot
un-publish or publish a page from the pages table.
@mamhoff mamhoff force-pushed the fix-page-publication-fields-on-pages-table branch from 86fbd54 to e962459 Compare July 31, 2023 12:24
@tvdeyen tvdeyen merged commit 8a1bf01 into AlchemyCMS:main Jul 31, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants