Convert Dirty from Coffeescript to Javascript #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| return $(element).hasClass("dirty") | ||
| } | ||
|
|
||
| function checkPageDirtyness(element) { |
There was a problem hiding this comment.
Function checkPageDirtyness has 27 lines of code (exceeds 25 allowed). Consider refactoring.
sascha-karnatz
force-pushed
the
move-dirty.js-into-app-javascript
branch
from
1154ed2 to
bf3f486
Compare
sascha-karnatz
force-pushed
the
move-dirty.js-into-app-javascript
branch
2 times, most recently
from
6129e4c to
9bd0277
Compare
|
@sascha-karnatz needs a rebase now that #2509 has been merged |
tvdeyen
requested changes
Jul 31, 2023
sascha-karnatz
force-pushed
the
move-dirty.js-into-app-javascript
branch
2 times, most recently
from
9d7fea2 to
50d3e7d
Compare
Done. It was a missing function. |
Also move the file to app/javascript folder.
sascha-karnatz
force-pushed
the
move-dirty.js-into-app-javascript
branch
from
50d3e7d to
04740e0
Compare
tvdeyen
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Convert dirty.js.coffee to dirty.js and move the file into app/javascript.
Checklist