[6.0] Do not eager load elements in pages controller #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wuservices would you mind to test out this PR by referencing the branch in your local gem "alchemy_cms", git: "https://github.com/tvdeyen/alchemy_cms", branch: "6.0-do-not-eager-load-elements-on-page" |
tvdeyen
changed the title
|
@tvdeyen thanks for the speedy fix! Verified in my test repo and our real project. 🚀 |
Pages make use of fragment caching and we cannot know which element is cached. Therefore we cannot know what to eager load. Closes AlchemyCMS#2468 This partially reverts commit 0aa84d0.
tvdeyen
force-pushed
the
6.0-do-not-eager-load-elements-on-page
branch
from
f39ac51 to
3462603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #2472 but for 6.0-stable
Closes #2468