Allow editors to switch language #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a multi-language site with an editor user, and they're not able to switch to another language without this patch. Not sure whether switching languages should at all be protected by CanCanCan; maybe it's a good idea to just skip the authorize_resource before action on the Alchemy::Admin::LanguagesController#switch instead. I'm also not sure about all the other roles. Should they be able to switch language?
tvdeyen
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
I have a multi-language site with an editor user, and they're not able to switch to another language without this patch.
Not sure whether switching languages should at all be protected by CanCanCan; maybe it's a good idea to just skip the authorize_resource before action on the Alchemy::Admin::LanguagesController#switch instead.
I'm also not sure about all the other roles. Should they be able to switch language?
Checklist