Allow to add anchors to ingredients #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
add-anchors
branch
4 times, most recently
from
5fbff21 to
15e8bf1
Compare
We have a essence picture edit view spec, but not one for the ingredient.
This allows to be able to link to the ingredient with an anchor.
tvdeyen
force-pushed
the
add-anchors
branch
2 times, most recently
from
7035ed4 to
ec06e5b
Compare
tvdeyen
changed the title
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mamhoff
approved these changes
Dec 15, 2022
Text ingredients are often used as headlines or section
headings. Those should be linkable with anchor links.
You need to enable this in the ingredients settings
- name: headline
type: Text
settings:
anchor: true
Headlines are often linked to with anchor links.
You need to enable this in the ingredients settings
- name: headline
type: Headline
settings:
anchor: true
Will be used by admins only to load ingredients for the DOM ID select in the link dialog.
We now have ingredients that have dom_id stored that we can use as anchor in the link dialog.
There might be data attributes on ingredient classes, that do not have corosponding attributes on the essence class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Allow to set anchors on headline and text ingredients
It is common to add so called anchors (technically they are
dom_ids) and link to them from the same page as jump marks or from posts and mails.In order to use this for Headline and Text ingredients you need to enable this in the ingredients settings:
Screenshots
Checklist