Deprecate Alchemy::Element.available #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
reviewed
Apr 22, 2022
2 tasks
This is just an alias to "published", which in turn is an alias for `where(public: true)`. In most circumstances, using this in production code will break preloading.
There were some usages in relations that I replaced with the synonym `published`. In the `ElementsFinder` I used `select(&:public?)` for performance reasons (it's extremely unlikely a page has so many elements that we need the database to help us).
mamhoff
force-pushed
the
deprecate-element-available
branch
from
9978fa9 to
94f46c2
Compare
tvdeyen
approved these changes
Apr 26, 2022
tvdeyen
added a commit
that referenced
this pull request
Apr 26, 2022
Deprecate Alchemy::Element.available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This removes a scope that is a synonym for another scope. I believe we should be using the
Enumerablemodule much more often rather than using scopes, as that will make preloading easier.I could have also removed the
publishedscope, but I like that it is close to the instance methodpublic.Notable changes (remove if none)
Alchemy will issue a deprecation warning when
Alchemy::Element.availableis called.Checklist