Fix page tagging condition: should_attach_to_menu? #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mickenorlen rebasing with latest |
mickenorlen
force-pushed
the
fix-page-tagging-menu-attach-cond
branch
from
431a512 to
2f2a2e6
Compare
houndci-bot
reviewed
Feb 24, 2020
mickenorlen
force-pushed
the
fix-page-tagging-menu-attach-cond
branch
from
2f2a2e6 to
b55b41b
Compare
mickenorlen
force-pushed
the
fix-page-tagging-menu-attach-cond
branch
from
b55b41b to
a13d617
Compare
|
I guess I have to continuously commit --amend and force push to stay in single commit? Why don't you just squash merge the whole PR instead? |
I depends on how many commits are inside a PR. With small fixes like this it is ok to squash merge, but there are PRs that have a set of useful (git history wise) commits that needs to be preserved. Also it puts burden on the maintainer. And this burden is already very huge. For this PR is is fine, though |
Closed
tvdeyen
added a commit
that referenced
this pull request
Feb 25, 2020
- Do not use deprecated methods [#1737](#1737) ([tvdeyen](https://github.com/tvdeyen)) - Order contents by their position in its element [#1733](#1733) ([tvdeyen](https://github.com/tvdeyen)) - Eager load relations in elements trash [#1732](#1732) ([tvdeyen](https://github.com/tvdeyen)) - Run CI builds with Sprockets 3.7.2 [#1731](#1731) ([tvdeyen](https://github.com/tvdeyen)) - Re-organize development dependencies [#1730](#1730) ([tvdeyen](https://github.com/tvdeyen)) - Update pr template [#1729](#1729) ([tvdeyen](https://github.com/tvdeyen)) - Generate views without _view in the filename [#1728](#1728) ([tvdeyen](https://github.com/tvdeyen)) - Fix CI Builds [#1727](#1727) ([tvdeyen](https://github.com/tvdeyen)) - Fix page tagging condition: should_attach_to_menu? [#1725](#1725) ([mickenorlen](https://github.com/mickenorlen)) - Fix Alchemy.user_class_name constant conflict [#1724](#1724) ([mickenorlen](https://github.com/mickenorlen))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
When tagging a page I got this error due to menu_id being an empty string, so i updated the condition.