Update upgrader #1558
Merged
Update upgrader #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 2, 2019
- Replace `elements.published` with `elements.available` in cell views - Capture all method calls in `cell.elements` replacement - Update regex of `render_elements from_cell` replacement for Ruby 1.8 Hash syntax
Add task that updates the element view partials so they use the element's partial name as local variable name.
Make the changes more prominent
Make the upgrade todos more pleasent to read and use a more prominent layout.
tvdeyen
force-pushed
the
fix-cell-upgrader
branch
from
711c4cc to
e5118a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Update the upgrader tasks and add an upgrader that replaces the local
elementvariable in the element view partials with the elementspartial_nameand therefore follow Rails conventions.Notable changes
elements.publishedwithelements.availablein cell viewscell.elementsreplacementrender_elements from_cellreplacement for Ruby 1.8 Hash syntax