Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade factory_bot_rails to version 5.0.0 #1539

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Feb 2, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ factory_bot_rails (~> 4.5 → ~> 5.0) · Repo · Changelog

Release Notes

5.0.0

  • Added: calling reload! in the Rails console will reload any factory definition files that have changed
  • Added: support for custom generator templates
  • Added: definition_file_paths configuration option, making it easier to place factories in custom locations
  • Changed: namespaced models are now generated inside a directory matching the namespace
  • Changed: added newline between factories generated into the same file
  • Removed: support for EOL version of Ruby and Rails

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 32 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Feb 2, 2019
@codeclimate
Copy link

codeclimate bot commented Feb 2, 2019

Code Climate has analyzed commit 60eab04 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 91.3% (0.0% change).

View more on Code Climate.

@depfu
Copy link
Contributor Author

depfu bot commented Feb 9, 2019

Closed in favor of #1540.

@depfu depfu bot closed this Feb 9, 2019
@depfu depfu bot deleted the depfu/update/factory_bot_rails-5.0.0 branch February 9, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants