Upgrade factory_bot_rails to version 5.0.0 #1539
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ factory_bot_rails (~> 4.5 → ~> 5.0) · Repo · Changelog
Release Notes
5.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 32 commits:
Bump version to 5.0.0 [ci skip]
Update README section about generator template
Avoid committing factory_bot_rails-*.gem files
Bump version to 5.0.0.rc2 [ci skip]
Bump version to 5.0.0.rc1 [ci skip]
Use an older version of bundler
Run CI on Ruby 2.6
Bump required version for factory_bot and railties
Make it more obvious which Gemfile groups to use
Update development dependencies [ci skip]
Fix incorrect escaping [ci skip]
Generate namespaced factories in a directory
Allow using custom template for the generator
Add newline between factories in same file
Be more consistent with path formatting [skip ci]
Update Appraisals
Configure Hound to use custom .rubocop.yml
Fix remaining RuboCop TODOs
Address todos generated by rubocop for files in the lib/generators directory (#299)
Address todos generated by rubocop for gemfiles and gemspec files (#295)
Address todos generated by rubocop for files in the features/ directory. (#297)
Address todos generated by rubocop for files in Rakefile and Appraisals. (#298)
Address todos generated by rubocop for files starting with lib/factory_bot_rails (#296)
Unclosed String literal in README
Fix syntax error in documentation for `filename_proc` option
Add RuboCop configuration
Update documentation to include new configuration
Introduce definition file path configuration
Remove unneeded conditional for app_generators
Allow reloading of factory definitions
Add standard thoughtbot CODE_OF_CONDUCT.md
Stop testing old Ruby and Rails versions
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands