Fix removing picture essences #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A rebase with master should fix the build |
Prior to this commit, removing a picture would not work because the click handler for the delete button would delete the input field, removing Rails' ability to actually update the content.
mamhoff
force-pushed
the
fix-deleting-pictures
branch
from
756e927 to
dc0ae56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
This fixes removing picture essences in the element editor.
Notable changes (remove if none)
Prior to this commit, removing a picture would not
work because the click handler for the delete button
would delete the input field, removing Rails' ability
to actually update the content.