Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #1438

Merged
merged 5 commits into from
Sep 18, 2018
Merged

Update README.md #1438

merged 5 commits into from
Sep 18, 2018

Conversation

aaongr
Copy link
Contributor

@aaongr aaongr commented May 11, 2018

Minor changes in the readme file

@aaongr
Update README.md
a8c5ed2 
Minor changes in the readme file
tvdeyen
tvdeyen requested changes May 11, 2018
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have some changes that need to be addressed before we can merge this.

README.md Outdated

That's why after Alchemy gem has been updated, with explicit call to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the Alchemy gem has been updated:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (see pm in slack)

README.md Outdated
```
or with a general call:
```shell
$ bundle update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this second paragraph.

We do not advice our users to do a general bundle update. This is never a good idea as this updates all dependencies at once and this can lead to lots of problems, especially if you don’t have gem version constraints (what most projects don’t have).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (see pm in slack)

README.md Outdated
@@ -316,7 +322,7 @@ Alchemy specs are written **in RSpec 3**. Please **do not use deprecated RSpec 2
* Read the guidelines: http://guides.alchemy-cms.com.
* Read the documentation: http://rubydoc.info/github/AlchemyCMS/alchemy_cms
* If you found a bug please use the [issue tracker on Github](https://github.com/AlchemyCMS/alchemy_cms/issues).
* For questions about general usage please use [Stack Overflow](http://stackoverflow.com/questions/tagged/alchemy-cms), [the User Group](http://groups.google.com/group/alchemy-cms) or the [IRC channel](irc://irc.freenode.net#alchemy_cms).
* For questions about general usage please use [Slack](https://alchemy-cms.slack.com), [Stack Overflow](http://stackoverflow.com/questions/tagged/alchemy-cms), [the User Group](http://groups.google.com/group/alchemy-cms) or the [IRC channel](irc://irc.freenode.net#alchemy_cms).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not replace the "Stack Overflow" notice.

You could instead replace the IRC one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?
I did not replace the "Stack Overflow", it exists after the "Slack"...
Can you please explain more?
Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. You are right. I misread this. Please replace the IRC part with the Slack link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done...
I would suggest changing also the label...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated
@@ -329,6 +335,7 @@ Alchemy specs are written **in RSpec 3**. Please **do not use deprecated RSpec 2
* API Documentation: <http://rubydoc.info/github/AlchemyCMS/alchemy_cms>
* Issue-Tracker: <https://github.com/AlchemyCMS/alchemy_cms/issues>
* Sourcecode: <https://github.com/AlchemyCMS/alchemy_cms>
* Slack: <https://alchemy-cms.slack.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please replace the IRC with Slack?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand what would you like to change...
Should I delete the IRC line in total?
Should I keep the IRC and put the Slack address in place of the IRC address?
Should I move the Slack line in the "place" of IRC line and delete the IRC line?
Please advise
Thank you

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I said. Replace the IRC line with a link to Slack.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done...
I would suggest changing also the label...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done...
Changed also the label...

aaongr added 3 commits June 5, 2018 09:11
@aaongr
Update (2nd) README.md
d764adf 
Minor changes (2nd) in the readme file
@aaongr
Update (3rd) README.md
33b0134 
Minor changes (3rd) in the readme file
@aaongr
Update (4th) README.md
9f8a948 
Minor changes (4th) in the readme file
@aaongr
Copy link
Contributor Author

aaongr commented Jun 6, 2018

Are we OK now?
Are there any other changes?

tvdeyen
tvdeyen requested changes Jun 6, 2018
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that the link to Slack need to be changed

README.md Outdated
@@ -316,7 +318,7 @@ Alchemy specs are written **in RSpec 3**. Please **do not use deprecated RSpec 2
* Read the guidelines: http://guides.alchemy-cms.com.
* Read the documentation: http://rubydoc.info/github/AlchemyCMS/alchemy_cms
* If you found a bug please use the [issue tracker on Github](https://github.com/AlchemyCMS/alchemy_cms/issues).
* For questions about general usage please use [Stack Overflow](http://stackoverflow.com/questions/tagged/alchemy-cms), [the User Group](http://groups.google.com/group/alchemy-cms) or the [IRC channel](irc://irc.freenode.net#alchemy_cms).
* For questions about general usage please use [Stack Overflow](http://stackoverflow.com/questions/tagged/alchemy-cms), [the User Group](http://groups.google.com/group/alchemy-cms) or the [Slack](https://alchemy-cms.slack.com).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to slack should be

https://slackin.alchemy-cms.com

README.md Outdated
@@ -330,7 +332,7 @@ Alchemy specs are written **in RSpec 3**. Please **do not use deprecated RSpec 2
* Issue-Tracker: <https://github.com/AlchemyCMS/alchemy_cms/issues>
* Sourcecode: <https://github.com/AlchemyCMS/alchemy_cms>
* User Group: <http://groups.google.com/group/alchemy-cms>
* IRC Channel: <irc://irc.freenode.net#alchemy_cms>
* Slack: <https://alchemy-cms.slack.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

@tvdeyen tvdeyen added this to the 4.1 milestone Sep 18, 2018
tvdeyen
tvdeyen approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the Slack URL myself. Thanks for contributing

@tvdeyen tvdeyen merged commit 972683b into AlchemyCMS:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@aaongr @tvdeyen