Fixes image cropping #1321
Merged
Fixes image cropping #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content's settings - which we use to merge with the default EssencePicture `picture_url` options - are a `HashWithIndifferentAccess`. But the default url options were a simple `Hash` instead. Merging these two leads to url options having the `format` and `size` keys duplicated once as `String` once as `Symbol`. By using a `HashWithIndifferentAccess` for the `picture_url_options` we fix that.
Content's settings - which we use to merge with the EssencePictureView default options - are a `HashWithIndifferentAccess`. But the default options were a simple `Hash` instead. Merging these two leads to url options having the `format` and `size` keys duplicated once as `String` once as `Symbol`. By using a `HashWithIndifferentAccess` for the `DEFAULT_OPTIONS` we fix that.
An image can always be cropped if upsample is set to true. We do not need to make the sizes from string conversion on each render of an essence picture when we know it can be upsampled.
EssencePicture crop values (`crop_from` and `crop_size`) should not be converted to a string if they are not set (`nil`) on save.
Having empty strings as EssencePicture crop value (`crop_from` or `crop_size`) causes imagemagick to not crop the image but resize only. Fixes AlchemyCMS#1279
robinboening
approved these changes
Nov 4, 2017
Only if the crop option is set explicitly to true we crop the image, even if `crop_from` or `crop_size` values are given. This is a change to current behavior where the image was always cropped if `crop_from` or `crop_size` values were given, even if `crop` was set to `false` or left `nil`. This is a very confusing behavior. Fixes AlchemyCMS#934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #1320
Closes #1279