Convert ProductLink tab into web component #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
fix-product-link
branch
2 times, most recently
from
588d0b9 to
f6868c8
Compare
|
This looks all good to me, but the tests are very broken... |
|
Yes, but totally unrelated. |
mamhoff
reviewed
May 23, 2024
mamhoff
reviewed
May 23, 2024
Alchemy 7.2 converted the link dialog into a view component. The current view partials and javascript does not work anymore. Adding a alchemy-product-select web component.
We need current main branch of Alchemy because the Link Dialog has a breaking change and do not support older Alchemy versions anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alchemy 7.2 converted the link dialog into a view component.
The current view partials and javascript does not work anymore.
Adding a
alchemy-product-selectweb component.