Do not create thumbs for invalid pictures #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a picture has validation errors (ie. an invalid format) a cryptic exception is raised: "You cannot call create unless the parent is saved" Let's not try to create a thumb if the picture is invalid.
DX FTW
Alchemy has an error tracking notifier. Let's use it.
tvdeyen
force-pushed
the
do-not-create-thumbs-for-invalid-pictures
branch
from
83d045f to
f5d694e
Compare
mamhoff
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a picture has validation errors (ie. an invalid format)
a cryptic exception is raised:
"You cannot call create unless the parent is saved"
Let's not try to create a thumb if the picture is invalid.