Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally set classes #12

Closed
wants to merge 1 commit into from
Closed

Conditionally set classes #12

wants to merge 1 commit into from

Conversation

afdev82
Copy link
Contributor

@afdev82 afdev82 commented Jun 10, 2021

Fixes #10.

It allows to include the gem for all environment and set different datastores if needed in the dragonfly configuration

@afdev82 afdev82 changed the title conditionally set classes WIP: conditionally set classes Jun 10, 2021
@afdev82
Copy link
Contributor Author

afdev82 commented Jun 10, 2021

I'm still testing this, something is odd

@afdev82 afdev82 changed the title WIP: conditionally set classes Conditionally set classes Jun 10, 2021
@afdev82
Copy link
Contributor Author

afdev82 commented Jun 10, 2021

All ok, it was spring... 😬

tvdeyen
tvdeyen reviewed Oct 2, 2021
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but as already explained in #10 it is not the responsibility of this gem

@tvdeyen tvdeyen closed this Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors when using different data stores based on the environment
2 participants
@afdev82 @tvdeyen